🦋 Changeset detected

Latest commit: b2fc39e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Awesome stuff, thanks so much @AmirSa12 🙏

I've left a comment regarding the completions setup, could you take a look? 😄

Also could you advise on how I can manually test this feature? 🙂 (is there a setup required, etc...)

Thank you, @dario-piotrowicz!
Yeah sure!
if you want to test the package manager completions, you can simply do that by first, isntalling tab: npm install -g @bomb.sh/tab and then source the script: source <(tab pnpm zsh) ( if you are using pnpm and zsh... npm, bun, and yarn are also supported ) then you can simply have tab completions and do pnpm <TAB>
the above works for your current shell session only, if you want to have that permanently, you would want to add it to ~/.zshrc

on top of this, if you have your own cli, you can have completions for that as well, and if your cli is executed through a package manager, and supports tab completions, lets assume wrangler does, the next example would also work: pnpm wrangler <TAB>

Awesome stuff, thanks so much @AmirSa12 🙏
I've left a comment regarding the completions setup, could you take a look? 😄
Also could you advise on how I can manually test this feature? 🙂 (is there a setup required, etc...)

Thank you, @dario-piotrowicz! Yeah sure! if you want to test the package manager completions, you can simply do that by first, isntalling tab: npm install -g @bomb.sh/tab and then source the script: source <(tab pnpm zsh) ( if you are using pnpm and zsh... npm, bun, and yarn are also supported ) then you can simply have tab completions and do pnpm <TAB> the above works for your current shell session only, if you want to have that permanently, you would want to add it to ~/.zshrc

on top of this, if you have your own cli, you can have completions for that as well, and if your cli is executed through a package manager, and supports tab completions, lets assume wrangler does, the next example would also work: pnpm wrangler <TAB>

Thanks @AmirSa12 😄

So... if I understand correctly for pnpm wrangler <TAB> to work I (and every wrangler user) need to globally install the @bomb.sh/tab package and enable it in my terminal?

Awesome stuff, thanks so much @AmirSa12 🙏
I've left a comment regarding the completions setup, could you take a look? 😄
Also could you advise on how I can manually test this feature? 🙂 (is there a setup required, etc...)

Thank you, @dario-piotrowicz! Yeah sure! if you want to test the package manager completions, you can simply do that by first, isntalling tab: npm install -g @bomb.sh/tab and then source the script: source <(tab pnpm zsh) ( if you are using pnpm and zsh... npm, bun, and yarn are also supported ) then you can simply have tab completions and do pnpm <TAB> the above works for your current shell session only, if you want to have that permanently, you would want to add it to ~/.zshrc
on top of this, if you have your own cli, you can have completions for that as well, and if your cli is executed through a package manager, and supports tab completions, lets assume wrangler does, the next example would also work: pnpm wrangler <TAB>

Thanks @AmirSa12 😄

So... if I understand correctly for pnpm wrangler <TAB> to work I (and every wrangler user) need to globally install the @bomb.sh/tab package and enable it in my terminal?

@dario-piotrowicz, the whole tab package relies on shell scripts.. all the magic happens in the shell, so in-order to have the completions, we need a shell script ( think of it as a plugin ) to inject in our terminal. by installing tab, you are only injecting the shell script, in other ways this means you can directly do source <(npx '@bomb.sh/tab' pnpm zsh) without installing the package globally, but installing the package is recommended because tab completions would be faster that way! let me know if that makes sense to you or if you have feedback or any other questions!
Almost in most of the completion systems, this script injection is required.

dario-piotrowicz, the whole tab package relies on shell scripts.. all the magic happens in the shell, so in-order to have the completions, we need a shell script ( think of it as a plugin ) to inject in our terminal. by installing tab, you are only injecting the shell script, in other ways this means you can directly do source <(npx '@bomb.sh/tab' pnpm zsh) without installing the package globally, but installing the package is recommended because tab completions would be faster that way! let me know if that makes sense to you or if you have feedback or any other questions! Almost in most of the completion systems, this script injection is required.

I see, great! thanks for the clarification 😄🙏

@dario-piotrowicz , I'm amazed by what I could achieve via the experimental_getWranglerCommands ! thank you for suggesting that! this is better now.
FYI NuxtCLI also follows a similar approach here: https://github.com/nuxt/cli/pull/1082/files#diff-985455627f7b91035ad2df15aeb5461a9da8da1305d47ef492654bf0b449c019R3

but one note, I noticed that, by using this function, we are only handling options that have explicit choices defined in the command args (like log-level) some option values (like --port values) are not included. let me know if you want to add common defaults for these common options (like port numbers: 8787, 8080, 3000, or protocols: http, https and ..)

Thank you for your contribution @AmirSa12, however we have decided to move forward with #11637 instead as it offers both a bit more in-house control of this feature and a test suite to match.

Hey!
Thanks for checking the PR ❤️

I'd like to add some context and technical details regarding the approaches used in both this PR and #11637
one of the main strengths of bomb.sh/tab is that it provides package manager shell completions, which is something the other PR( #11637 ) approach does not currently address... This approach includes npm, pnpm, yarn and bun support which is a huge win for user experience! (pnpm wrangler <TAB>) and also package.json and fs completions!

On top of this, tab also supports Windows PowerShell... this is a notable advantage as PowerShell support is often missing or incomplete is many completions solutions!

from a quality and reliability standpoint, tests can be added for this PR as well.

tab library provides a simple api for defining completions in your cli tool... which includes commands, options, positional arguments, and custom handlers for dynamic suggestions!
tab also supports framework adapters (CAC, Citty, Commander.js), which makes it easier to integrate with many cli ecosystems.

If this approach is still not desired, I recommend an alternative to be the cli tool wrangler is using (yargs) as it provides completions. however it’s important to note that yargs completion also lacks package manager integration and powershell support.

Additionally, we're happy to add tests or address any missing features or gaps you think tab has as part of this work, so those improvements can be included here and benefit other users as well.

cc @dario-piotrowicz @NuroDev @ascorbic @dmmulroy

Hey @AmirSa12, is there anything else needed on this or do you need any help with anything? Happy to lend a hand to help get this over the line and merged 😄

hey @NuroDev, sorry for the inactivity, we've had some personal issues on the side, i'll look into this and see if i can move it forward!

ok i had a look, i think as you suggested, maybe we can merge this PR and open another PR later that can add more choices to those options not having them or adding custom handlers that handle those options.

It might take more work so splitting it up in another PR might be a quicker and cleaner way to do this. This way when @AmirSa12 is back, he can have a serious look at it too.

Let me know what you think @NuroDev, and again, really sorry for the delay!

thank you so much team for this, we really appreciate it.